chore: upgrade to Python 3.8+ and modernize CI#329
Open
vaibhavchopra-wq wants to merge 7 commits into
Open
Conversation
- Python: 3.4+ → >=3.8 - requests: any → >=2.28.0 - CI: test Python 3.8, 3.9, 3.10, 3.11, 3.12 - GitHub Actions: v2/v3 → v4/v5 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…duplicate workflow - Remove pkg_resources fallback (deprecated in Python 3.12+, not needed for Python 3.8+) - Use importlib.metadata directly (available since Python 3.8) - Fix hardcoded fallback version 1.4.3 → 2.0.1 - Delete duplicate python.yml workflow (ci.yml is the primary) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Replace `python setup.py install` with `pip install .` (modern approach) - Extract version from setup.py using grep instead of `setup.py --version` - setuptools is not pre-installed in Python 3.12+ GitHub runners Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Don't change release status in chore PR - that's a release decision. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Raise minimum Python to 3.10 (3.8/3.9 are EOL) - Add Python 3.13 to test matrix and classifiers - Keep 3.9 in test matrix for broader compatibility testing - Use robust regex for version extraction (handles single/double quotes) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Cannot test on 3.9 when python_requires='>=3.10' Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Minimum: >=3.11 (EOL Oct 2027, gives 1.5 years runway) - Test matrix: 3.11, 3.12, 3.13, 3.14 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
ankitdas13
reviewed
Jun 4, 2026
| import importlib.metadata | ||
| version = importlib.metadata.version("razorpay") | ||
| except importlib.metadata.PackageNotFoundError: # pragma: no cover | ||
| version = "2.0.1" |
Contributor
There was a problem hiding this comment.
please check this once is it backward compatible or not ?
also check this PR why i had added these changes.
Author
|
Thanks for the review! Re: backward compatibility of removing The change is backward compatible for our new minimum Python version (3.11+). Here's the reasoning:
Since we're bumping minimum Python to 3.11, the
The fallback to hardcoded version only triggers if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code