Closed
Conversation
|
|
AdityaKasar
force-pushed
the
test/mock-tests
branch
from
166436f to
1bb26f8
Compare
tomasz-blasz
requested changes
Mar 25, 2025
Contributor
There was a problem hiding this comment.
When code is merged to next-bidirectional, compilation of Core SDK fails with the log as attached - compilation-err.log
Merge was done:
- firebolt-openrpc: test/mock-tests(
b2f171e) to next-bidirectional(e7d19eb) - firebolt-apis: test/mock-tests(
1bb26f8) to next-bidirectional(4884ced)
Then, Core SDK generated.
Then, compilation of the SDK failed.
Please, update the code to be compilable and also address review comments for corresponding PR in firebolt-openrpc.
AdityaKasar
force-pushed
the
test/mock-tests
branch
2 times, most recently
from
6386bd9 to
202162d
Compare
AdityaKasar
force-pushed
the
test/mock-tests
branch
from
202162d to
ad1eae7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.