Conversation
feature: CI/CD Merges (next->next-major and next->main)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| fContents = fContents.replace(/\$\{module\.init\}/g, Object.values(macros.moduleInit)[0]) | ||
|
|
||
| Object.keys(macros.moduleInit).forEach(key => { | ||
| const regex = new RegExp('\\$\\{module\.init\\:' + key + '\\}', 'gms') |
Check failure
Code scanning / CodeQL
Useless regular-expression character escape
Contributor
|
Coverity detected 1 issue; a quality concern. |
| }) | ||
|
|
||
| return json | ||
| const notifiers = json.methods.filter( m => m.tags && m.tags.find(t => t.name == 'notifier')) || [] |
Contributor
There was a problem hiding this comment.
Medium impact. Quality issue.
Control flow issues. Structurally dead code.
Code block is unreachable because of the syntactic structure of the code
Actions intended to be performed by the unreachable code will never occur.
Contributor
Contributor
WARNING: A Blackduck scan failure has been waivedA prior failure has been upvoted
|
also added support for `firebolt-openrpc.config.json` file to override language settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.