Skip to content

expose current file when encountering validation error#185

Open
alkalinecoffee wants to merge 1 commit intordkcentral:nextfrom
alkalinecoffee:current-module-log
Open

expose current file when encountering validation error#185
alkalinecoffee wants to merge 1 commit intordkcentral:nextfrom
alkalinecoffee:current-module-log

Conversation

@alkalinecoffee
Copy link
Copy Markdown
Contributor

@alkalinecoffee alkalinecoffee commented May 2, 2024

The output from any errors that occur during validation do not include the file causing the failure.

This PR wraps the validation logic into a larger try block so that the failing file name is clearly displayed.

Before:

 ✓  OpenRPC & Firebolt: Lifecycle is valid
 ✓  OpenRPC & Firebolt: Localization is valid
file:///Users/jmarti350/src/firebolt-apis/node_modules/@firebolt-js/openrpc/src/validate/index.mjs:208
                                                                "value": method.result.schema
                                                                                       ^

After:

 ✓  OpenRPC & Firebolt: Lifecycle is valid
 ✓  OpenRPC & Firebolt: Localization is valid
 ✗  Error parsing /media_info.json

file:///Users/jmarti350/src/firebolt-apis/node_modules/@firebolt-js/openrpc/src/validate/index.mjs:209
                                                                    "value": method.result.schema
                                                                                           ^

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 2, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants