SERXIONE-8115: Fix exception handling in DisplaySettings::Request() by reordering function calls

[Copilot]

In DisplaySettings::Request(), if setAllmEnabled() throws an exception, setAVIContentType() and setAVIScanInformation() are never called due to incorrect ordering.

Changes

• Moved setAllmEnabled() call to execute after setAVIContentType() and setAVIScanInformation() in the Request() method

Before:

bool enable = (newState == "GAME") ? true : false;
vPort.getDisplay().setAllmEnabled(enable);
if(enable){
    vPort.getDisplay().setAVIContentType(dsAVICONTENT_TYPE_GAME);
    vPort.getDisplay().setAVIScanInformation(dsAVI_SCAN_TYPE_UNDERSCAN);
}else{
    vPort.getDisplay().setAVIContentType(dsAVICONTENT_TYPE_NOT_SIGNALLED);
    vPort.getDisplay().setAVIScanInformation(dsAVI_SCAN_TYPE_NO_DATA);
}

After:

bool enable = (newState == "GAME") ? true : false;
if(enable){
    vPort.getDisplay().setAVIContentType(dsAVICONTENT_TYPE_GAME);
    vPort.getDisplay().setAVIScanInformation(dsAVI_SCAN_TYPE_UNDERSCAN);
}else{
    vPort.getDisplay().setAVIContentType(dsAVICONTENT_TYPE_NOT_SIGNALLED);
    vPort.getDisplay().setAVIScanInformation(dsAVI_SCAN_TYPE_NO_DATA);
}
vPort.getDisplay().setAllmEnabled(enable);

Original prompt

On DisplaySettings.cpp, in DisplaySettings::Request() function setAllmEnabled() should be called after setAVIContentType() and setAVIScanInformation() are called. otherwise if setAllmEnabled() has an exception, the other two function are not called either.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Pull Request Overview

This PR fixes a potential issue in the DisplaySettings module where an exception in setAllmEnabled() would prevent the execution of setAVIContentType() and setAVIScanInformation(). By reordering these function calls, the critical AVI configuration methods are guaranteed to execute before the potentially failing setAllmEnabled() call.

Key Changes:

• Moved setAllmEnabled() call to execute after the AVI-related function calls in the game mode state handling logic

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.