website: make testimonials reusable includes - #435
Draft
ericholscher wants to merge 3 commits into
Draft
Conversation
Two of our four testimonials sat commented out on the homepage and appeared nowhere, and each of the others was inlined into a single page, so reusing one meant copying markup. Each quote is now an include rendering just the card, which lets pages control their own layout: the homepage runs two side by side, everything else runs one centered. Placement follows the main nav, so every quote sits on a page a reader can actually reach. Godot and JupyterGIS stay on the homepage. Ouranos goes on the Product page, and Kedro's quote about navigation and search-as-you-type on the reader features page. JupyterGIS also appears on the Jupyter Book page and Ouranos on the comparisons hub, which is the reuse the includes are for. The homepage still has no quote from a commercial customer. The business logos above it remain unattributed, so a company testimonial is still worth chasing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012L9idsbsKVqLVJLY1qgCMu
Documentation build overview
11 files changed ·
|
…l-includes-w8poca
Jupyter Book was unlinked from the site in #436, so a testimonial there sits on a page nothing navigates to. The same quote already runs on the homepage, so nothing is lost by removing this copy. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012L9idsbsKVqLVJLY1qgCMu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had four testimonials and were getting value from two of them. The Ouranos and Kedro quotes were sitting inside a Jinja comment block on the homepage, so they rendered nowhere at all, and each of the other two was inlined into a single page — reusing one meant copying its markup.
Each quote is now an include under
content/includes/, next to the existingusers-*includes. They render just the card rather than a whole section, so pages keep control of their own layout: the homepage runs two side by side, everything else runs one centered. That's what lets the Ouranos quote appear on both Product and the comparisons hub without the quote text living in two places.Placement follows the main nav so each quote is somewhere a reader can actually get to. Godot and JupyterGIS run side by side on the homepage; Ouranos goes on Product; Kedro's quote about the new top navigation and search-as-you-type goes on the reader features page, which is what it's actually describing, and Product links onward to it.
This branch has been merged with main and re-verified against it. That merge changed one decision: #436 unlinked Jupyter Book from the site, so the JupyterGIS testimonial that had been on
/tools/jupyter-book/was removed rather than left on a page nothing navigates to. The quote still runs on the homepage, so all four testimonials remain in use.Two things a reviewer might want to weigh in on:
The homepage still has no quote from a commercial customer — all four testimonials are from open source projects, while the logos above them (AMD, Canonical, Anaconda, Acquia) are unattributed. Getting one company quote would let the homepage pair a community voice with a business one, and would give the enterprise page some proof it currently lacks.
The comparisons hub is reachable only from the footer, so the quote there is a bonus placement rather than that testimonial's real home. Linking comparisons from Product would fix that, but it's a nav decision rather than something to slip into this PR.
Verified with a production build on the merge result: all four quotes render on the intended pages, the homepage pair lays out in two columns, and the new sections use
id="quotes"so they don't collide with theid="testimonials"already used by theusers-*includes.🤖 Generated with Claude Code