This repository was archived by the owner on Nov 1, 2021. It is now read-only.
feat: HtmlVideoElement, HtmlMediaElement, TextTrack, VideoTrack#196
Open
illusionalsagacity wants to merge 6 commits intoreasonml-community:masterfrom
Open
feat: HtmlVideoElement, HtmlMediaElement, TextTrack, VideoTrack#196illusionalsagacity wants to merge 6 commits intoreasonml-community:masterfrom
illusionalsagacity wants to merge 6 commits intoreasonml-community:masterfrom
Conversation
| module Impl = (T: {type t;}) => { | ||
| type t_htmlMediaElement = T.t; | ||
|
|
||
| type mediaProvider; // TODO: one of MediaStream, MediaSource, or Blob |
Contributor
Author
There was a problem hiding this comment.
Thinking this might be a Webapi__MediaProvider.t instead of a local phantom type
kazcw
reviewed
Sep 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got a couple of questions here;
Should we append
Exnfor methods that potentially throw? Or maybe we catch it for convenience and return a result?Along the same lines, I put in some variants to hold the enums in some (but not all) cases. I kinda like this, as it makes life easier when consuming the bindings. But, willing to remove entirely or cover the other ones. The main problem I ran into was I couldn't type a return value as:
So hiding the binding and then wrapping is necessary.
fixes #173