pre-commit handling#394
Draft
mpoberezhniy wants to merge 1 commit intoredhat-plumbers-in-action:mainfrom
Draft
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
+ Coverage 84.96% 85.17% +0.20%
==========================================
Files 4 4
Lines 286 290 +4
==========================================
+ Hits 243 247 +4
Misses 43 43 ☔ View full report in Codecov by Sentry. |
mpoberezhniy
commented
Apr 29, 2024
| - id: differential-shellcheck | ||
| name: Differential ShellCheck | ||
| description: Static analysis tool for changed shell scripts | ||
| language: docker |
Contributor
Author
There was a problem hiding this comment.
This is temporary, docker_image should be used when ready.
6bc612e to
5f80422
Compare
5f80422 to
6fa4c10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #234
Testing: I created a tag in my fork and used the following yaml for pre-commit testing.
TODO: