Skip to content

Comments

Remove unused leftovers from JedisSharding#4348

Open
uglide wants to merge 4 commits intomasterfrom
im/remove-leftovers-from-sharding
Open

Remove unused leftovers from JedisSharding#4348
uglide wants to merge 4 commits intomasterfrom
im/remove-leftovers-from-sharding

Conversation

@uglide
Copy link
Contributor

@uglide uglide commented Nov 5, 2025

Continuation of #4311

@uglide uglide requested a review from ggivo November 5, 2025 08:58
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Test Results

   285 files  ±0    285 suites  ±0   11m 29s ⏱️ -52s
10 469 tests ±0  9 199 ✅  - 1 212  1 270 💤 +1 212  0 ❌ ±0 
 2 774 runs  ±0  2 770 ✅ ±    0      4 💤 ±    0  0 ❌ ±0 

Results for commit 2e0a383. ± Comparison against base commit a768c35.

This pull request skips 1212 tests.
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHgetdel
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHgetdelBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHgetex
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHgetexBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHsetex
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHsetexBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[2] ‑ testHgetdel
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[2] ‑ testHgetdelBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[2] ‑ testHgetex
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[2] ‑ testHgetexBinary
…

♻️ This comment has been updated with latest results.

@ggivo ggivo added the breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. label Nov 5, 2025
@uglide
Copy link
Contributor Author

uglide commented Nov 5, 2025

@ggivo I don't think it's a breaking change, since the files are internal and not used extrernaly.

@ggivo
Copy link
Collaborator

ggivo commented Nov 6, 2025

@uglide
What do you mean by not used externaly?
They are marked @deprecated but are public and not documented as internal in comments or annotated with @internal.

@uglide
Copy link
Contributor Author

uglide commented Nov 6, 2025

@ggivo see https://github.com/redis/jedis/pull/4311/files#diff-a1c95bbe6e3dc70afb41f29448973d7f61021891667a064b67d5bbc2603748b3L32-L35
This PR removes leftovers that were overseen during the JedisSharding removal. Hashing was used only for JedisSharding and is unlikely to be used without it.

@ggivo ggivo added this to the 8.0.0 milestone Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants