Skip to content

Comments

Refactor TLS tests#4431

Merged
uglide merged 14 commits intomasterfrom
im/mtls-tests
Feb 13, 2026
Merged

Refactor TLS tests#4431
uglide merged 14 commits intomasterfrom
im/mtls-tests

Conversation

@uglide
Copy link
Contributor

@uglide uglide commented Feb 13, 2026

Move TLS tests to sub package and use stable cluster endpoint

@github-actions
Copy link

github-actions bot commented Feb 13, 2026

Test Results

   302 files  + 5     302 suites  +5   12m 4s ⏱️ -27s
10 910 tests +19  10 693 ✅  - 140  217 💤 +159  0 ❌ ±0 
 2 842 runs  +19   2 833 ✅ + 14    9 💤 +  5  0 ❌ ±0 

Results for commit 3aa0e1f. ± Comparison against base commit 2ab42df.

This pull request removes 85 and adds 104 tests. Note that renamed tests count towards both.
redis.clients.jedis.RedisClusterClientTest ‑ clusterLinks2
redis.clients.jedis.RedisClusterClientTest ‑ clusterPeriodTopologyRefreshTest
redis.clients.jedis.RedisClusterClientTest ‑ clusterRefreshNodes
redis.clients.jedis.RedisClusterClientTest ‑ testAskResponse
redis.clients.jedis.RedisClusterClientTest ‑ testAskResponseWithConfig
redis.clients.jedis.RedisClusterClientTest ‑ testCalculateConnectionPerSlot
redis.clients.jedis.RedisClusterClientTest ‑ testCloseable
redis.clients.jedis.RedisClusterClientTest ‑ testCloseableWithConfig
redis.clients.jedis.RedisClusterClientTest ‑ testClusterCountKeysInSlot
redis.clients.jedis.RedisClusterClientTest ‑ testClusterFlushSlots
…
redis.clients.jedis.UnboundRedisClusterClientTest ‑ clusterLinks2
redis.clients.jedis.UnboundRedisClusterClientTest ‑ clusterPeriodTopologyRefreshTest
redis.clients.jedis.UnboundRedisClusterClientTest ‑ clusterRefreshNodes
redis.clients.jedis.UnboundRedisClusterClientTest ‑ testAskResponse
redis.clients.jedis.UnboundRedisClusterClientTest ‑ testAskResponseWithConfig
redis.clients.jedis.UnboundRedisClusterClientTest ‑ testCalculateConnectionPerSlot
redis.clients.jedis.UnboundRedisClusterClientTest ‑ testCloseable
redis.clients.jedis.UnboundRedisClusterClientTest ‑ testCloseableWithConfig
redis.clients.jedis.UnboundRedisClusterClientTest ‑ testClusterCountKeysInSlot
redis.clients.jedis.UnboundRedisClusterClientTest ‑ testClusterFlushSlots
…
This pull request skips 159 tests.
redis.clients.jedis.commands.jedis.ClusterHotkeysCommandsTest ‑ hotkeysGetNotSupportedInCluster
redis.clients.jedis.commands.jedis.ClusterHotkeysCommandsTest ‑ hotkeysResetNotSupportedInCluster
redis.clients.jedis.commands.jedis.ClusterHotkeysCommandsTest ‑ hotkeysStartNotSupportedInCluster
redis.clients.jedis.commands.jedis.ClusterHotkeysCommandsTest ‑ hotkeysStopNotSupportedInCluster
redis.clients.jedis.commands.jedis.ClusterHotkeysCommandsTest ‑ hotkeysWithSlotsOnSingleClusterNode
redis.clients.jedis.commands.jedis.HotkeysCommandsTest[1] ‑ hotkeysBothMetrics
redis.clients.jedis.commands.jedis.HotkeysCommandsTest[1] ‑ hotkeysDurationOption
redis.clients.jedis.commands.jedis.HotkeysCommandsTest[1] ‑ hotkeysGetBeforeStart
redis.clients.jedis.commands.jedis.HotkeysCommandsTest[1] ‑ hotkeysLifecycle
redis.clients.jedis.commands.jedis.HotkeysCommandsTest[1] ‑ hotkeysResponseFields
…

♻️ This comment has been updated with latest results.

@uglide uglide requested review from Copilot and ggivo and removed request for Copilot February 13, 2026 11:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors TLS-related tests by moving them to a new redis.clients.jedis.tls sub-package and consolidating their configuration to use the cluster-stable-tls endpoint instead of cluster-unbound-tls. The refactoring improves test organization and uses a more stable 6-node cluster configuration.

Changes:

  • Moved all TLS test classes to redis.clients.jedis.tls package with consistent "IT" suffix naming
  • Introduced TLSRedisClusterTestBase to provide common TLS setup for cluster tests
  • Removed TLS configuration from cluster-unbound endpoint and deleted the cluster-unbound-tls endpoint
  • Configured cluster-stable with TLS support (without mandatory client authentication)

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/test/resources/env/docker-compose.yml Removed TLS from cluster-unbound; added TLS ports and configuration to cluster-stable with client auth disabled
src/test/resources/env/cluster-unbound/config/node-*.conf Removed tls-port and tls-auth-clients settings from all 5 node configs
src/test/resources/endpoints.json Removed cluster-unbound-tls endpoint definition
src/test/java/redis/clients/jedis/tls/TLSRedisClusterTestBase.java New base class providing common TLS setup including truststore and keystore configuration
src/test/java/redis/clients/jedis/tls/SSLRedisClusterClientIT.java Moved and refactored from root package; now uses cluster-stable-tls and expects 6 nodes
src/test/java/redis/clients/jedis/tls/SSLOptionsRedisClusterClientIT.java Moved and refactored from root package; updated to use new base class
src/test/java/redis/clients/jedis/tls/SSLACLRedisClusterClientIT.java Moved and refactored from root package; ACL-specific TLS tests
src/test/java/redis/clients/jedis/tls/SSLJedisIT.java Moved from root package with formatting cleanup
src/test/java/redis/clients/jedis/tls/SSLACLJedisIT.java Moved from root package with formatting cleanup
src/test/java/redis/clients/jedis/tls/SSLJedisSentinelPoolIT.java Moved from root package with formatting cleanup
src/test/java/redis/clients/jedis/tls/SSLOptionsJedisIT.java Moved from root package with minor cleanup
src/test/java/redis/clients/jedis/tls/SSLOptionsRedisClientIT.java Moved from root package with minor cleanup
src/test/java/redis/clients/jedis/tls/SSLOptionsJedisSentinelPoolIT.java Moved from root package with formatting cleanup
src/test/java/redis/clients/jedis/commands/jedis/ClusterCommandsTest.java Removed assertion for tls-port (no longer applicable after config changes)
src/test/java/redis/clients/jedis/UnboundRedisClusterClientTestBase.java Fixed class name from RedisClusterClientTestBase
src/test/java/redis/clients/jedis/UnboundRedisClusterClientTest.java Updated to extend renamed UnboundRedisClusterClientTestBase

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ggivo
ggivo previously approved these changes Feb 13, 2026
Copy link
Collaborator

@ggivo ggivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Now that tests are moved inside tls package, we can strip SSL/TLS prefix from class names

- Add abstract test classes to reduce code duplications
- Add more tests to cover all client classes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@uglide uglide merged commit cc42541 into master Feb 13, 2026
19 of 21 checks passed
@uglide uglide deleted the im/mtls-tests branch February 13, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants