Conversation
- Introduce TLSRedisClusterTestBase - Refactor Cluster TLS tests to use cluster-stable endpoints - Update docker config and endpoints
Test Results 302 files + 5 302 suites +5 12m 4s ⏱️ -27s Results for commit 3aa0e1f. ± Comparison against base commit 2ab42df. This pull request removes 85 and adds 104 tests. Note that renamed tests count towards both.This pull request skips 159 tests.♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull request overview
This pull request refactors TLS-related tests by moving them to a new redis.clients.jedis.tls sub-package and consolidating their configuration to use the cluster-stable-tls endpoint instead of cluster-unbound-tls. The refactoring improves test organization and uses a more stable 6-node cluster configuration.
Changes:
- Moved all TLS test classes to
redis.clients.jedis.tlspackage with consistent "IT" suffix naming - Introduced
TLSRedisClusterTestBaseto provide common TLS setup for cluster tests - Removed TLS configuration from cluster-unbound endpoint and deleted the
cluster-unbound-tlsendpoint - Configured cluster-stable with TLS support (without mandatory client authentication)
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/test/resources/env/docker-compose.yml |
Removed TLS from cluster-unbound; added TLS ports and configuration to cluster-stable with client auth disabled |
src/test/resources/env/cluster-unbound/config/node-*.conf |
Removed tls-port and tls-auth-clients settings from all 5 node configs |
src/test/resources/endpoints.json |
Removed cluster-unbound-tls endpoint definition |
src/test/java/redis/clients/jedis/tls/TLSRedisClusterTestBase.java |
New base class providing common TLS setup including truststore and keystore configuration |
src/test/java/redis/clients/jedis/tls/SSLRedisClusterClientIT.java |
Moved and refactored from root package; now uses cluster-stable-tls and expects 6 nodes |
src/test/java/redis/clients/jedis/tls/SSLOptionsRedisClusterClientIT.java |
Moved and refactored from root package; updated to use new base class |
src/test/java/redis/clients/jedis/tls/SSLACLRedisClusterClientIT.java |
Moved and refactored from root package; ACL-specific TLS tests |
src/test/java/redis/clients/jedis/tls/SSLJedisIT.java |
Moved from root package with formatting cleanup |
src/test/java/redis/clients/jedis/tls/SSLACLJedisIT.java |
Moved from root package with formatting cleanup |
src/test/java/redis/clients/jedis/tls/SSLJedisSentinelPoolIT.java |
Moved from root package with formatting cleanup |
src/test/java/redis/clients/jedis/tls/SSLOptionsJedisIT.java |
Moved from root package with minor cleanup |
src/test/java/redis/clients/jedis/tls/SSLOptionsRedisClientIT.java |
Moved from root package with minor cleanup |
src/test/java/redis/clients/jedis/tls/SSLOptionsJedisSentinelPoolIT.java |
Moved from root package with formatting cleanup |
src/test/java/redis/clients/jedis/commands/jedis/ClusterCommandsTest.java |
Removed assertion for tls-port (no longer applicable after config changes) |
src/test/java/redis/clients/jedis/UnboundRedisClusterClientTestBase.java |
Fixed class name from RedisClusterClientTestBase |
src/test/java/redis/clients/jedis/UnboundRedisClusterClientTest.java |
Updated to extend renamed UnboundRedisClusterClientTestBase |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/test/java/redis/clients/jedis/tls/TLSRedisClusterTestBase.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/tls/TLSRedisClusterTestBase.java
Outdated
Show resolved
Hide resolved
- Add abstract test classes to reduce code duplications - Add more tests to cover all client classes
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 36 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Move TLS tests to sub package and use stable cluster endpoint