Fix sharded pubsub auto-resubscription after Redis cluster rebalancing#3400
Open
byunjuneseok wants to merge 4 commits intoredis:mainfrom
Open
Fix sharded pubsub auto-resubscription after Redis cluster rebalancing#3400byunjuneseok wants to merge 4 commits intoredis:mainfrom
byunjuneseok wants to merge 4 commits intoredis:mainfrom
Conversation
3e6a13f to
f2fc1ee
Compare
f2fc1ee to
cf1b45c
Compare
Author
|
@tishun // Hi, I noticed this PR is marked for Best, |
Collaborator
|
Apologies, we need to find the resources to check this out before we proceed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.Summary
Fixes missing auto-resubscription for Sharded Pub/Sub after Redis cluster rebalancing.
Issues
Fixes
Result
Sharded Pub/Sub subscriptions now automatically resubscribe on slot rebalancing while preserving intentional client unsubscribe behavior.