Conversation
a-TODO-rov
force-pushed
the
enable-keepalive
branch
from
9d2469d to
eae7be4
Compare
tishun
reviewed
Feb 19, 2026
Comment on lines
+327
to
+331
| public static final int DEFAULT_COUNT = 3; | ||
|
|
||
| public static final Duration DEFAULT_IDLE = Duration.ofHours(2); | ||
| public static final Duration DEFAULT_IDLE = Duration.ofSeconds(13); | ||
|
|
||
| public static final Duration DEFAULT_INTERVAL = Duration.ofSeconds(75); | ||
| public static final Duration DEFAULT_INTERVAL = Duration.ofSeconds(13); |
Collaborator
There was a problem hiding this comment.
I would have gone with more attempts:
50 = 10 + 5 * 8
TCP_USER_TIMEOUT = 50
TCP_KEEPIDLE = 10
TCP_KEEPINTVL = 8
TCP_KEEPCNT = 5
My logic : in a more congested network more attempts may yield at least one successful attempt, while bigger intervals wont help get a package though.
You will basically drop more congested connections that might be redeemable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.