shard_connection: Handle non-blocking I/O errors on Unix socket client connect#258
Open
LINKIWI wants to merge 1 commit intoredis:masterfrom
Open
shard_connection: Handle non-blocking I/O errors on Unix socket client connect#258LINKIWI wants to merge 1 commit intoredis:masterfrom
LINKIWI wants to merge 1 commit intoredis:masterfrom
Conversation
2a27e54 to
7ff52af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the client socket is configured as non-blocking, but non-blocking I/O errors are not properly handled on
connect(2). (Reference)This seems to be problematic for Unix socket clients, where a restrictive server TCP listen backlog (or a restrictive system setting for
net.core.somaxconn) relative to the number of concurrent memtier_benchmark clients (--clients) results in persistent benchmark execution failures withResource temporarily unavailable.A simple reproduction case:
This patch augments the
connect(2)path to handleEINPROGRESSandEAGAIN/EWOULDBLOCKerrors; the connect is simply retried indefinitely for the latter case.With this patch: