allow URI parameters for http appender - #385
Open
dmitry-sinina wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Appender::Httpkeeps only the path when parsing the url. Everything after ? is dropped silently. url: "http://host/path?foo=bar" posts to /path.Description of changes
The query is kept next to the path and appended when each request uri is built.
Motivation
Log servers configured through query parameters cannot be used with this appender. VictoriaLogs takes its field mapping in the url: /insert/jsonline?_msg_field=message&_time_field=timestamp&_stream_fields=application,environment
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.