Conversation
|
Hmm, this seems to be failing with npm 7 because of upstream peer dependencies, too - filed a PR |
Yep. The react-katex dependency causes some issues with npm7, but only in development mode. Will create a separate PR to get rid of it and simplify the tests it's used in. |
|
Not sure there's much we can do about the tests failing - seems to be because of upstream enzyme adapter peer dependency ranges. Did you want more changes here, @wooorm? Or should we leave it until the official enzyme adapter is out? |
|
An official version seems to get closers: enzymejs/enzyme#2430 (comment). I’m fine with the changes here and using the other package now, but I’m unhappy with the failing tests 😬 The enzyme PR also mentions a PR to proptypes too, which seems to be coming after the enzyme update. |
* Fix to remove 15, which didn’t work anymore: this would normally be breaking (and we take deprecating older versions seriously), but as it didn’t work before, this change instead catches problems earlier * Allow React 17 (and later) as a peer dependency: we can’t actually add code to test this yet because we’re waiting for our test frameworks to update too (see GH-498), but checking locally React 17 seems supported Related to: GH-498.
|
I’ve unlocked the package already, this PR can add tests for it later when enzyme updates. |
|
A possible way to unblock this would be to migrate from enzyme to testing library react, which supports React 17. |
|
Synced with develop, the |
This comment has been minimized.
This comment has been minimized.
5 participants
Upgrades the peer dependency version range to support React 17, and uses React 17 for the tests. Switches to using the unofficial
@wojtekmaj/enzyme-adapter-react-17adapter for enzyme, for now (until the official adapter is released).On a slightly unrelated note - I'm not sure I agree that
@types/reactshould be a peer dependency?Closes GH-497.