Skip to content

feat(ci) - add zizmor to do static analysis on github actions#256

Merged
gabrielseco merged 4 commits into
mainfrom
zizmor-scan
May 25, 2026
Merged

feat(ci) - add zizmor to do static analysis on github actions#256
gabrielseco merged 4 commits into
mainfrom
zizmor-scan

Conversation

@gabrielseco
Copy link
Copy Markdown
Collaborator

@gabrielseco gabrielseco commented May 25, 2026

After tanstack supply chain incident, we install zizmor to do static analysis on the github actions and prevent security incidents...

Whenever a github action changes, zizmor will run

Run the fix script to fix the errors and add some docs about the tool as you need to install it globally


Note

Low Risk
CI and workflow-only changes that reduce supply-chain and credential exposure; no application runtime or auth logic is modified.

Overview
Adds zizmor static analysis for GitHub Actions: a new workflow runs on PRs and main when .github/workflows/*.yml changes, and pnpm run lint:workflows / lint:workflows:fix are documented in CONTRIBUTING.md.

Hardens existing PR workflows (actions.yml, actions-v0.yml) with workflow-level contents: read, pinned action SHAs (checkout, setup-node, cache, pnpm), and persist-credentials: false on checkout. The main PR workflow drops the separate git submodule update --init step while keeping submodule checkout via actions/checkout.

Reviewed by Cursor Bugbot for commit 0073fe5. Bugbot is set up for automated code reviews on this repo. Configure here.

@gabrielseco gabrielseco self-assigned this May 25, 2026
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@gabrielseco gabrielseco changed the title zizmor feat(ci) - add zizmor to do static analysis on github actions May 25, 2026
@gabrielseco gabrielseco marked this pull request as ready for review May 25, 2026 07:44
@gabrielseco gabrielseco requested a review from sandrina-p May 25, 2026 07:47
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0d60c72. Configure here.

Comment thread .github/workflows/actions.yml
Comment thread .github/workflows/zizmor.yml Outdated
Copy link
Copy Markdown
Collaborator

@sandrina-p sandrina-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 pipelines are passing, so hopefully we won't need to revert this

@gabrielseco gabrielseco merged commit 0600423 into main May 25, 2026
8 checks passed
@gabrielseco gabrielseco deleted the zizmor-scan branch May 25, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants