Enable prefer_const_constructors lint and apply across all packages#351
Open
quetool wants to merge 1 commit intoreown-com:tron_servicefrom
Open
Enable prefer_const_constructors lint and apply across all packages#351quetool wants to merge 1 commit intoreown-com:tron_servicefrom
quetool wants to merge 1 commit intoreown-com:tron_servicefrom
Conversation
- Add prefer_const_constructors and avoid_field_initializers_in_const_classes lint rules to analysis_options.yaml in all packages - Apply const keyword to constructor invocations throughout the codebase - Convert final field initializers to getters in const classes (basic_event.dart _ErrorOptions, _ModalTrackOptions) - Standardize analysis_options.yaml in pos_client to use package:lints/recommended.yaml - Sort dependencies in pubspec.yaml files - Switch to local path dependencies for development Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
prefer_const_constructorsandavoid_field_initializers_in_const_classeslint rules toanalysis_options.yamlin all packagesconstkeyword to constructor invocations throughout the codebase whichanalysis_options.yamlin pos_client to use package:lints/recommended.yamlRationale: Using const keyword in static objects leads to a much better performance improvement leveraging Dart's canonicalization and reusability
Resolves # (issue)
How Has This Been Tested?
Due Dilligence