Add basic documentation#37
Open
brodeuralexis wants to merge 1 commit intorequest:masterfrom
brodeuralexis:doc
Open
Add basic documentation#37brodeuralexis wants to merge 1 commit intorequest:masterfrom brodeuralexis:doc
brodeuralexis wants to merge 1 commit intorequest:masterfrom
brodeuralexis:doc
Conversation
gfgqtmakia
reviewed
Jun 11, 2017
| var https = require("https"); | ||
|
|
||
| var options = {}; | ||
| http.globalAgent = new ForeverAgent(options); |
There was a problem hiding this comment.
Does this actually works?
Have you checked that http.globalAgent can be replaced?
nodejs/node#9057
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking to use this module, I was not able to find documentation on how to use it anywhere. I had to peek at the source code to understand how to use it. I'm leaving this here for future reference for myself, as well as for others
Related issue #22