Remove usage of legacy build system from build tests #8179
Merged
+272
−422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
nojaf
reviewed
Jan 16, 2026
|
|
||
| const { execBuildLegacy, execCleanLegacy } = setup(import.meta.dirname); | ||
| // Deactivated because of https://github.com/rescript-lang/rescript/issues/8178 | ||
| process.exit(0); |
Member
There was a problem hiding this comment.
I feel more inclined to fix #8178 first and not shortcut here.
Yes, that would mean you are not able to remove execBuildLegacy, execCleanLegacy but it would be better to highlight we are not there yet.
| * @param {ExecOptions} [options] | ||
| * @return {Promise<ExecResult>} | ||
| */ | ||
| execBuildLegacy(args = [], options = {}) { |
Member
There was a problem hiding this comment.
See other comment, but I would not remove this just yet.
# Conflicts: # tests/build_tests/duplicated_symlinked_packages/input.js
cknitt
force-pushed
the
remove-legacy-builds
branch
from
d34710f to
cc251b2
Compare
Member
Author
|
@nojaf Rebased |
nojaf
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build Tests: Rewatch Migration
Summary
This change set migrates build tests off the legacy build system and onto the rewatch CLI, updating expectations where output/behavior differs.
Removed
tests/build_tests/in_source(legacy ninja-regenbehavior, followup Rewatch allows two different package specs with the same suffix #8177)tests/build_tests/install(legacy ninja-installbehavior)tests/build_tests/scoped_ppx(legacy ninja command forwarding)tests/build_tests/xpkg(package name_error, followup Rewatch: reserved package names #8176)