test: add unit tests for device manager functionality#1507
Closed
sawirricardo wants to merge 6 commits into
Closed
test: add unit tests for device manager functionality#1507sawirricardo wants to merge 6 commits into
sawirricardo wants to merge 6 commits into
Conversation
Add comprehensive unit tests for the device manager Redux slice and sanitizeSuites utility function. Covers: - setDevices, setActiveSuite, addSuite, addSuites (merge logic) - setSuiteDevices, deleteSuite, deleteAllSuites - selectActiveSuite selector with fallback behavior - sanitizeSuites: null/empty suites, invalid device ID filtering, dirty vs clean state Fixes responsively-org#934
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive unit tests for the device manager Redux slice and the
sanitizeSuitesutility, addressing issue #934.Device manager slice tests (
index.test.ts)setDevices— replaces device list, handles empty arraysetActiveSuite— updates active suite idaddSuite— appends suite and makes it activeaddSuites— merge logic with name collision (incoming wins)setSuiteDevices— updates devices for existing suite, no-op for missing suitedeleteSuite— removes suite and resets activeSuite, no-op for missing iddeleteAllSuites— resets to default single suiteselectActiveSuiteselector — returns matching suite, falls back to firstsanitizeSuites tests (
utils.test.ts)All 17 tests pass with
vitest run.Fixes #934