Open
Conversation
atenart
changed the title
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #607 +/- ##
==========================================
- Coverage 37.12% 37.10% -0.03%
==========================================
Files 111 111
Lines 13370 13381 +11
Branches 13370 13381 +11
==========================================
+ Hits 4964 4965 +1
- Misses 8025 8036 +11
+ Partials 381 380 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
atenart
force-pushed
the
at/python-rotate
branch
from
b812d09 to
bf4c787
Compare
Provide an event file representation in the events crate directly, to allow bundling a path with attributes (e.g. how it should be used wrt the rotation policy). Use it in InputDataFile and in FileEventsFactory (allowing to embed to rotation vs non-rotation logic directly). Signed-off-by: Antoine Tenart <atenart@redhat.com>
Add support from reading rotated event files from PyEventFile and PyEventReader. We use class methods to provide alternative constructors. Signed-off-by: Antoine Tenart <atenart@redhat.com>
Signed-off-by: Antoine Tenart <atenart@redhat.com>
Signed-off-by: Antoine Tenart <atenart@redhat.com>
Handling the file name fallback from {file} to {file}.0 in the "library"
(retis-events) is not common: the RotationReader and its helpers are magically
handling things in a non-deterministic way. Such choice (the fallback) should
instead be done at the consumer level, in the Retis option parsing logic.
Signed-off-by: Antoine Tenart <atenart@redhat.com>
atenart
force-pushed
the
at/python-rotate
branch
from
bf4c787 to
55e6027
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some pre-requisites required to convey the rotation config down to the Python helpers. This is actually improving things for all users.