Open
Conversation
Contributor
vlrpl
commented
Mar 13, 2026
vlrpl
commented
- generalize proto_state (w/ compat)
- add sctp
- update doc
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage 37.09% 37.09%
=======================================
Files 111 111
Lines 13392 13402 +10
Branches 13392 13402 +10
=======================================
+ Hits 4968 4972 +4
- Misses 8041 8046 +5
- Partials 383 384 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
atenart
reviewed
Mar 16, 2026
| .btf | ||
| .resolve_types_by_name("tcp_conntrack") | ||
| { | ||
| fn parse_proto_states(&mut self, flag: u32, btf_name: &str, prefix: &str) -> Result<()> { |
Contributor
There was a problem hiding this comment.
Looks like we could reuse parse_enum instead.
| }; | ||
| let proto_state = [RETIS_CT_PROTO_TCP, RETIS_CT_PROTO_SCTP] | ||
| .iter() | ||
| .find(|&&f| flags & f != 0) |
Contributor
There was a problem hiding this comment.
nit: I think a single & is enough.
Rename tcp_state to proto_state in the BPF event struct and Rust side to make it protocol-agnostic. Signed-off-by: Paolo Valerio <pvalerio@redhat.com>
Add SCTP to the list of protocols tracked by the conntrack collector. Signed-off-by: Paolo Valerio <pvalerio@redhat.com>
Generalize tcp state and add SCTP. Signed-off-by: Paolo Valerio <pvalerio@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.