Added WrapperPlayServerUnlockRecipes#382
Open
NoJokeFNA wants to merge 5 commits intoretrooper:2.0from
Open
Conversation
Jaren8r
suggested changes
May 12, 2022
NoJokeFNA
changed the title
Owner
|
Interesting how you have modern and legacy recipe "inits"? I don't know if its possible to bring them into one form? If possible I don't want different fields available for different versions. |
Contributor
Author
|
I know that, but I honestly don't know how we could make it different. We could use Objects, but you don't really wanna have Objects. |
NoJokeFNA
force-pushed
the
feat/unlock-recipes-wrapper
branch
from
1a0b13b to
0b4fc87
Compare
Contributor
|
Use a Wrapper object inside of the WrapperPlayServerUnlockRecipes for the field instead of an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wiki.vg/Protocol#Unlock_Recipes (1.14 -> 1.18.2)
https://wiki.vg/index.php?title=Protocol&oldid=14299 (1.13)
https://wiki.vg/index.php?title=Protocol&oldid=12930 (1.12)
Tested Server-Versions: 1.12, 1.12.1, 1.12.2, 1.13.2, 1.14, 1.14.4, 1.15.2, 1.16.4, 1.18.2
Current issueI have some problems with server versions 1.14 to 1.15.2 always throwing an
IndexOutOfBoundsExceptioneven though nothing has changed in those versions, but I think there is a general problem with the versions and it is not the code's fault.The Client-Version doesn't matter in this case, I've tried it with multiple ones -> same issue.Logshttps://sourceb.in/gNedCXvso3