Skip to content

Support setting correct values for nested blocklists #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timoschraa wants to merge 3 commits into from
+4 −14
Closed

Support setting correct values for nested blocklists #285

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca3a0bc
Additional .ToString() isn't necessary because _blockGridEditorValues…
Mar 30, 2026
834efd7
Remove FormatBlockData when propertyData.EditorAlias == PropertyEdito…
Mar 30, 2026
fd0951c
Remove FormatBlockData when propertyData.EditorAlias == PropertyEdito…
Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions src/Umbraco.Community.BlockPreview/Services/BlockDataConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ public IPublishedElement ConvertToElement(BlockItemData data, IPublishedElement
{
var property = data.Values.ElementAt(i);
var value = property.Value;
string? propertyAsString = value?.ToString();

if (property.EditorAlias == PropertyEditors.Aliases.RichText)
{
Expand All @@ -116,7 +115,7 @@ public IPublishedElement ConvertToElement(BlockItemData data, IPublishedElement
}
if (property.EditorAlias == PropertyEditors.Aliases.BlockGrid)
{
var blockValue = _blockGridEditorValues.DeserializeAndClean(propertyAsString);
var blockValue = _blockGridEditorValues.DeserializeAndClean(value);
if (blockValue != null)
{
FormatBlockData(blockValue.BlockValue.ContentData);
Expand All @@ -126,7 +125,7 @@ public IPublishedElement ConvertToElement(BlockItemData data, IPublishedElement
}
if (property.EditorAlias == PropertyEditors.Aliases.BlockList)
{
var blockValue = _blockListEditorValues.DeserializeAndClean(propertyAsString);
var blockValue = _blockListEditorValues.DeserializeAndClean(value);
if (blockValue != null)
{
FormatBlockData(blockValue.BlockValue.ContentData);
Expand Down Expand Up @@ -172,31 +171,22 @@ public void FormatBlockData(List<BlockItemData>? blockData)
}
}
}

else if (propertyData.EditorAlias == PropertyEditors.Aliases.BlockGrid)
{
string? propertyAsString = propertyData.Value?.ToString();
var blockValue = _blockGridEditorValues.DeserializeAndClean(propertyAsString);
var blockValue = _blockGridEditorValues.DeserializeAndClean(propertyData.Value);
if (blockValue != null)
{
FormatBlockData(blockValue.BlockValue.ContentData);
FormatBlockData(blockValue.BlockValue.SettingsData);
propertyData.Value = JsonSerializer.Serialize(blockValue.BlockValue, _jsonSerializerOptions);
}
}

else if (propertyData.EditorAlias == PropertyEditors.Aliases.BlockList)
{
string? propertyAsString = propertyData.Value?.ToString();
var blockValue = _blockListEditorValues.DeserializeAndClean(propertyAsString);
var blockValue = _blockListEditorValues.DeserializeAndClean(propertyData.Value);
if (blockValue != null)
{
FormatBlockData(blockValue.BlockValue.ContentData);
FormatBlockData(blockValue.BlockValue.SettingsData);
propertyData.Value = JsonSerializer.Serialize(blockValue.BlockValue, _jsonSerializerOptions);
}
}

else ConvertPropertyValue(propertyData);
}
}
Expand Down