fix: add getsockopt shim and TLS SNI fix for curl WASM#1427
Open
airhorns wants to merge 1 commit intorivet-dev:mainfrom
Open
fix: add getsockopt shim and TLS SNI fix for curl WASM#1427airhorns wants to merge 1 commit intorivet-dev:mainfrom
airhorns wants to merge 1 commit intorivet-dev:mainfrom
Conversation
curl WASM tests were failing with exit code 7 (CURLE_COULDNT_CONNECT) because getsockopt() was not implemented in the WASI socket layer. curl calls getsockopt(SO_ERROR) after connect to verify the connection, and without it verifyconnect() always returned false. Additionally, HTTPS tests failed with exit code 35 (CURLE_SSL_CONNECT_ERROR) because Node.js rejects TLS servername (SNI) set to an IP address. The driver now skips SNI for IP address hostnames. Changes: - Add wasi_getsockopt.c overlay that routes getsockopt through host_net - Update build-curl-upstream.sh to compile and link the new shim - Skip TLS servername for IP addresses in driver.ts (net.isIP check) - Add missing WASI errno constants: EINPROGRESS, ENOTCONN, EMFILE, EMSGSIZE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curl WASM tests were failing with exit code 7 (CURLE_COULDNT_CONNECT) because getsockopt() was not implemented in the WASI socket layer. curl calls getsockopt(SO_ERROR) after connect to verify the connection, and without it verifyconnect() always returned false.
Additionally, HTTPS tests failed with exit code 35 (CURLE_SSL_CONNECT_ERROR) because Node.js rejects TLS servername (SNI) set to an IP address. The driver now skips SNI for IP address hostnames.
Changes: