Skip to content

chore: regenerate sdk#5036

Open
jog1t wants to merge 1 commit into
05-11-feat_frontend_allow_creating_serverfull_instances_during_onboardingfrom
05-11-fix_frontend_fix_actor_not_showing_up_in_the_actors_list
Open

chore: regenerate sdk#5036
jog1t wants to merge 1 commit into
05-11-feat_frontend_allow_creating_serverfull_instances_during_onboardingfrom
05-11-fix_frontend_fix_actor_not_showing_up_in_the_actors_list

Conversation

@jog1t
Copy link
Copy Markdown
Contributor

@jog1t jog1t commented May 11, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 11, 2026

Code Review: PR 5036

Three small frontend fixes - all targeted and correct.

1. getting-started.tsx - publishable token fallback

Correct fix. usePublishableToken() returns null for Enterprise/OSS deployments without a platform API. Without this fallback, buildRivetAgentInstructionsCode would embed the literal string 'null' into the generated shell snippet. The placeholder '<PUBLISHABLE_TOKEN>' is clear and consistent with other placeholder patterns in the codebase.

2. serverless-connection-check.tsx - new provider labels

Correct fix. Both cloudflare-workers and supabase-functions exist in deployOptions in frontend/packages/shared-data/src/deploy.ts and are part of the Provider union type. Without these arms, the ts-pattern .exhaustive() call would be a compile error (or runtime throw) when either provider was passed. The label strings match the displayName values in deployOptions. No inconsistency.

3. actors-list.tsx - useEffect rowVirtualizer.measure()

Functionally reasonable as a defensive measure to recalculate row sizes after mount.

Minor concern - dependency stability: useVirtualizer returns the same stable object reference across renders (it is a class instance). The [rowVirtualizer] dependency should therefore fire only once on mount, which is the intent. Worth confirming the reference is stable in the version in use; if it is not, this could fire on every render.

Minor concern - intent clarity: If the goal is mount-only, an empty [] dependency array would be more explicit. Using [rowVirtualizer] is not wrong, but it slightly obscures whether this is meant to track instance changes or just run once.

Suggestion: Add a brief comment explaining why an explicit measure() call is needed (e.g. dynamic row heights). Per project conventions, one short line is enough - the why is non-obvious here.

Assessment

All three changes are correct. No security issues, no regressions in error handling, no missing match arms. The only nit is the missing explanatory comment on the useEffect in actors-list.tsx.

@jog1t jog1t marked this pull request as ready for review May 11, 2026 18:42
@jog1t jog1t force-pushed the 05-11-fix_frontend_fix_actor_not_showing_up_in_the_actors_list branch from cf92344 to a3e0d8a Compare May 11, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant