Chore - Removes the preinstall hook to download Mapbox SDK#1
Merged
christophermark merged 1 commit intorobinpowered:masterfrom Apr 30, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Previously, as a
preinstallscript the Mapbox sdk was being downloaded from an S3 bucket everynpm install. Not only does this get cumbersome when reinstalling modules often, but a core native dependency (Mapbox) was located separately from our other dependencies.The goal here is remove this
preinstallscript so that we can instead install the Mapbox sdk via thePodfilealong with our other native deps.Currently there is a PR (nitaliano#1533) in the main repo which adds this change, but it is waiting for the next major release of this library. In the meantime, we will support this on our own fork.