fix: pinned models no longer block LRU eviction#2091
Merged
Conversation
hansent
requested review from
PawelPeczek-Roboflow,
dkosowski87,
grzegorz-roboflow,
probicheaux and
yeldarby
as code owners
The eviction loop used `for _ in range(3)`, so pinned models at the front of the queue consumed loop iterations without actually evicting anything. With 3+ pinned models as LRU, no eviction would occur and the cache would silently overflow. Switch to a while loop that only counts actual evictions toward the limit of 3. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hansent
force-pushed
the
fix/pinned-model-eviction-loop
branch
from
f863e40 to
29a3600
Compare
bigbitbus
approved these changes
Mar 6, 2026
grzegorz-roboflow
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
for _ in range(3)would exhaust all iterations skipping pinned models, causing the cache to silently overflowwhile evicted_count < 3 and self._key_queue:so only actual evictions count toward the limitRelated: #2048 (pinned models feature)
Test plan
🤖 Generated with Claude Code