Migrate launch files to XML version#315
Open
andreas-loeffler wants to merge 13 commits intoros-drivers:ros2from
Open
Migrate launch files to XML version#315andreas-loeffler wants to merge 13 commits intoros-drivers:ros2from
andreas-loeffler wants to merge 13 commits intoros-drivers:ros2from
Conversation
…h file for outdated py launch file Signed-off-by: Andreas Loeffler <73336148+andreas-loeffler@users.noreply.github.com>
…eq. launch file for outdated spacenav py launch file Signed-off-by: Andreas Loeffler <73336148+andreas-loeffler@users.noreply.github.com>
…ch file Signed-off-by: Andreas Loeffler <73336148+andreas-loeffler@users.noreply.github.com>
…ed spacenav launch files Signed-off-by: Andreas Loeffler <73336148+andreas-loeffler@users.noreply.github.com>
Contributor
|
Thanks! I'll have a look at this, but I won't be available for the next 2 weeks... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: Migrate python launch files to XML launch files
Closes #311 to replace .py launch files with XML equivalents across
joy,spacenav, andwiimote. Also adds a new XML launch file forjoy_linuxOverview
joy: Added joy-launch.xml (plain node) and joy-composed-launch.xml (composable node)joy_linux: Added new launch file joy_linux.launch.xml, the package had no .py launch equivalent before and because of the deprecation strategy only an XML version has been implementedspacenav: Added spacenav-launch.xml as the base launch file; classic-launch.xml, no_deadband-launch.xml, and static_deadband-launch.xml are derived versions that include the base with pre-configured params for their specific use casewiimote: Added feedback_test.launch.xml, turtlesim.launch.xml, and wiimote_lifecycle.launch.xmlFor every added XML launch file, its .py launch equivalent now emits a deprecation warning on lyrical and rolling
Notes
Following @peci1 suggestion, the .py launch files are kept for now but warn at launch time on lyrical and rolling (based on ROS_DISTRO env var). They can be removed once Jazzy reaches EOL (~2029)!
ps3joyis excluded, since it has not been ported to ROS2 yet