Skip to content

Added can device recovery code#469

Closed
akashmod wants to merge 1 commit intoros-industrial:melodic-develfrom
akashmod:melodic-devel
Closed

Added can device recovery code#469
akashmod wants to merge 1 commit intoros-industrial:melodic-develfrom
akashmod:melodic-devel

Conversation

@akashmod
Copy link
Copy Markdown

@akashmod akashmod commented Sep 1, 2022

This is to solve issue 468. A ros timer is started to check the driver state after every specified duration and to reinitialize the driver for the node if the driver has recovered.

@BenArtes
Copy link
Copy Markdown

Summary notes for any reviewers: This covers similar ground as PR #249 (5 years old and waiting for changes) and #310 (4 years old and VERY minimal).

I think whatever happens to the socketcan_bridge auto-recovery code, the ThreadedSocketCANInterface should be merged as a (potentially) separate PR as it fixes a seemingly missing piece from ThreadedSocketCANInterface recovery code (as I ran into in issue #467).

@BenArtes
Copy link
Copy Markdown

Also, shouldn't ThreadedSocketCANInterface virtual void recover have a bool return type?

@akashmod
Copy link
Copy Markdown
Author

The virtual void recover should have a bool return type yes. That needs to be corrected.

@carlesu
Copy link
Copy Markdown

carlesu commented Oct 7, 2022

Hello, Tank you very much!! This was giving me a big headache, because we actually have a device that has on/off using dead man button and had to restart the node in order to send new data. Been following #467 since then, this seems to solve the problem.

Is it possible to know approximately when could this be updated to noetic release?

Thank you again for the effort!

@akashmod akashmod closed this Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants