Complete Capsule export support and add public exportURDF API#256
Open
saikishor wants to merge 1 commit intoros:rollingfrom
Open
Complete Capsule export support and add public exportURDF API#256saikishor wants to merge 1 commit intoros:rollingfrom
saikishor wants to merge 1 commit intoros:rollingfrom
Conversation
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Contributor
Author
|
Needed for #230 |
scpeters
reviewed
Apr 20, 2026
| namespace urdf{ | ||
| URDFDOM_DLLAPI ModelInterfaceSharedPtr parseURDF(const std::string &xml_string); | ||
| URDFDOM_DLLAPI ModelInterfaceSharedPtr parseURDFFile(const std::string &path); | ||
| URDFDOM_DLLAPI std::string exportURDF(const ModelInterface &model); |
Contributor
Contributor
Author
There was a problem hiding this comment.
I tthink they are used to export the string from a Model, but not much use. If this is the case, then there needs to be other cleanups to be done. Should I do the cleanup part?
Contributor
There was a problem hiding this comment.
I don't think this is a breaking change, so we can merge to rolling after the freeze date and then backport to lyrical after the initial release
Contributor
There was a problem hiding this comment.
I tthink they are used to export the string from a Model, but not much use. If this is the case, then there needs to be other cleanups to be done. Should I do the cleanup part?
maybe create an issue to describe the cleanup work to be done and what it will enable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was reviewing the changes of the Capsule geometry just in case before the official release, and I found that this geomtry is not exported anywhere. I added a utility here to finish that part