Skip to content

Move the headers from .h to .hpp#100

Open
saikishor wants to merge 4 commits intoros:rollingfrom
saikishor:update/headers_to_hpp
Open

Move the headers from .h to .hpp#100
saikishor wants to merge 4 commits intoros:rollingfrom
saikishor:update/headers_to_hpp

Conversation

@saikishor
Copy link
Copy Markdown
Contributor

@saikishor saikishor commented Apr 6, 2026

As per the discussion over ros/urdfdom#230 (comment), I've moved the headers from .h to .hpp

saikishor added 2 commits April 6, 2026 20:42
@saikishor
Move all the .h headers to .hpp headers
cf61d87 
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
@saikishor
Create the .h and point to the new .hpp files
ff80def 
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
ahcorde
ahcorde requested changes Apr 7, 2026
View reviewed changes
Comment thread include/urdf_exception/exception.h
@saikishor
Add deprecation notices
b4048ab 
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
@saikishor saikishor requested a review from ahcorde April 9, 2026 07:26
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Apr 9, 2026

Pulls: ros/urdfdom#250, #100
Gist: https://gist.githubusercontent.com/ahcorde/611f4084b55e4ff274ccd7e0d732b66d/raw/5219abd04cbab827d14e82f2a4404462b5425fe8/ros2.repos
BUILD args: --packages-above-and-dependencies urdfdom_headers urdfdom
TEST args: --packages-above urdfdom_headers urdfdom
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18905

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request Apr 9, 2026
Open
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Apr 17, 2026

Pulls: ros/urdfdom#250, #100
Gist: https://gist.githubusercontent.com/ahcorde/f729e1d69297fe6c7e76fa4d420b5c7a/raw/5219abd04cbab827d14e82f2a4404462b5425fe8/ros2.repos
BUILD args: --packages-above-and-dependencies urdfdom_headers urdfdom
TEST args: --packages-above urdfdom_headers urdfdom
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18986

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

scpeters
scpeters reviewed Apr 17, 2026
View reviewed changes
Comment thread include/urdf_world/world.hpp Outdated
@scpeters scpeters force-pushed the update/headers_to_hpp branch from 060b044 to b4048ab Compare April 17, 2026 16:47
@scpeters
use urdf_model/types.hpp
65f6b29 
Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
@scpeters
Copy link
Copy Markdown
Contributor

scpeters commented Apr 17, 2026

Pulls: ros/urdfdom#250, #100 Gist: https://gist.githubusercontent.com/ahcorde/f729e1d69297fe6c7e76fa4d420b5c7a/raw/5219abd04cbab827d14e82f2a4404462b5425fe8/ros2.repos BUILD args: --packages-above-and-dependencies urdfdom_headers urdfdom TEST args: --packages-above urdfdom_headers urdfdom ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18986

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

CI is green but there are new downstream compiler warnings

@scpeters
Copy link
Copy Markdown
Contributor

scpeters commented Apr 17, 2026

including the changes in ros/urdfdom#250, there are downstream warnings in the following packages:

I think we should open pull requests in these repositories. We could also consider backporting .hpp files without deprecation notices to kilted

@saikishor
Copy link
Copy Markdown
Contributor Author

saikishor commented Apr 17, 2026

Sound good. I'll try to do it. BTW what do you think about the version.hpp header?

@scpeters
Copy link
Copy Markdown
Contributor

scpeters commented Apr 20, 2026

will merge this after the freeze and backport .hpp without deprecation to Lyrical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@scpeters scpeters scpeters approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saikishor @ahcorde @scpeters