Merged
Conversation
ahcorde
requested changes
Apr 8, 2024
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
LGTM, do you mind to sign the commit ?
Signed-off-by: Janosch Machowinski <j.machowinski@cellumation.com>
jmachowinski
force-pushed
the
timer_improvements2
branch
from
3662a7a to
d48a279
Compare
Contributor
Author
fixed |
alsora
approved these changes
Apr 8, 2024
Contributor
|
Contributor
Author
|
Can we merge this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup to #1146
These are just style changes suggested by @alsora that I pushed on the wrong branch, and thus did not end up in the PR.