Added rcl_timer_get_next_call_time (#1146)#1237
Conversation
|
Pulls: #1237
|
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@n8hui why we are seeing the difference from #1146 original fix? which includes the improvements and tests. if the PR can be backported to humble, maybe we should cherry-pick entire fix from #1146? my major concern is the test and stability for this additional function, currently this PR just picks up the new function and never tested in rcl.
|
@fujitatomoya I don't know, #1146 slightly alters the behavior of the waits. It does not fix a critical bug, just too much wakeups if simulation time is slower than real time. From my point of view Humble is outdated (event though official EOL is 2027) and its not worth the risk of introducing a regression of some kind. |
|
@jmachowinski thanks! yeah we obviously want to avoid possible regression for humble, totally agree. if that is the case, probably we could add some unit tests for this free function just to make sure that works fine with CI? @n8hui can you add unit tests for this function with this PR? |
|
Pulls: #1237
|
(cherry-picked from commit 2e9549c) Signed-off-by: Nathan Hui <205866820+n8hui@users.noreply.github.com>
Signed-off-by: Nathan Hui <205866820+n8hui@users.noreply.github.com>
|
Pulls: #1237
|
5 participants
Add function
rcl_timer_get_next_call_timeto support humble backport of rclpy EventsExecutor (ros2/rclpy#1454).Cherry-picked from commit 2e9549c (#1146)