Improved documentation of rcl_XYZ_set_on_new_XYZ_callback#1289
Open
rushsahay wants to merge 7 commits intoros2:rollingfrom
Open
Improved documentation of rcl_XYZ_set_on_new_XYZ_callback#1289rushsahay wants to merge 7 commits intoros2:rollingfrom
rushsahay wants to merge 7 commits intoros2:rollingfrom
Conversation
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
what about rcl_client_set_on_new_response_callback? i think that needs to be updated accordingly?
@jmachowinski can you review this?
Author
|
Thanks for spotting that! Have added the description to that method as well. Is there a reason why the "Rpr__rcl__ubuntu_noble_amd64" check is failing on this pull request? Let me know if I need to do something else to ensure it passes. |
Collaborator
|
@rushsahay DCO is missing, can you |
Contributor
|
The new text does not make any sense. |
* Populate Transitions Signed-off-by: CursedRock17 <mtglucas1@gmail.com> * Suspending timestamp until I find an ansewr Signed-off-by: CursedRock17 <mtglucas1@gmail.com> * Adding timestamp Signed-off-by: CursedRock17 <mtglucas1@gmail.com> * Simplify lifecycle event publication arguments Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com> * Add clock to rcl_lifecycle_com_interface Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com> * Update lifecycle transition event to use builtin_interfaces/Time Adds compatibility with ros2/rcl_interfaces#185 Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com> * Add explicit conversions Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com> --------- Signed-off-by: CursedRock17 <mtglucas1@gmail.com> Signed-off-by: SuperJappie08 <36795178+SuperJappie08@users.noreply.github.com> Co-authored-by: CursedRock17 <mtglucas1@gmail.com> Signed-off-by: Rushsahay <rushhaank.sahay@gmail.com>
Signed-off-by: Rushsahay <rushhaank.sahay@gmail.com>
Signed-off-by: Rushsahay <rushhaank.sahay@gmail.com>
Signed-off-by: Rushsahay <rushhaank.sahay@gmail.com>
Signed-off-by: Rushsahay <rushhaank.sahay@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Signed off: Rushhaank Sahay rushhaank.sahay@gmail.com
Updates the documentation for rcl_service_set_on_new_request_callback and rcl_subscription_set_on_new_message_callback methods to encourage users to make the process non-blocking and warn them of unexpected behavior if it is blocked
Fixes #1282
Addresses #1277
Is this user-facing behavior change?
Yes. It changes user behavior as it specifies to users the proper way to use these methods to avoid unexpected behaviors.
Did you use Generative AI?
No