return early with a zero-initialized array. (backport #1012) - #1018
Merged
Conversation
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com> (cherry picked from commit 22c4c20)
fujitatomoya
approved these changes
Jul 24, 2026
Author
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
|
Pulls: #1018
|
ahcorde
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of ros2/ros2cli#1210, but this is just a latent bug fix.
now returns early with a zero-initialized (empty) array when the service is known but has no endpoints of the requested type, instead of calling &endpoints[0] on an empty std::vector (assertion abort)
Fixes # (issue)
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information
This is an automatic backport of pull request #1012 done by [Mergify](https://mergify.com).