to support complete for rosidl and avoid calling multiple compinit#702
Open
iuhilnehc-ynos wants to merge 2 commits intoros2:rollingfrom
Open
to support complete for rosidl and avoid calling multiple compinit#702iuhilnehc-ynos wants to merge 2 commits intoros2:rollingfrom
iuhilnehc-ynos wants to merge 2 commits intoros2:rollingfrom
Conversation
Contributor
Author
|
to fix ros2/ros2_documentation#2944 |
2c0b1ed to
d8cacb3
Compare
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
|
Cross-ref ros2/ros2cli#534 |
|
If I understand correctly, this solution relies on checking whether functions Note however that this might not be a problem at all, I'm just documenting my observations. |
mjbogusz
added a commit
to mjbogusz/rosidl
that referenced
this pull request
Jan 17, 2023
Based on Chen Lihui's (@iuhilnehc-ynos) PR: ros2#702
mjbogusz
added a commit
to mjbogusz/rosidl
that referenced
this pull request
Jan 17, 2023
Based on Chen Lihui's (@iuhilnehc-ynos) PR: ros2#702 Signed-off-by: Maciej Bogusz <mjbogusz+github@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chen Lihui lihui.chen@sony.com