Pr routing preference priority #1271
Conversation
Summary of ChangesHello @mci77777, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the authentication token routing capabilities by introducing a two-tiered selection process. It first allows for a configurable preference to determine which group of tokens (provider-based or credential-based) should be considered. Subsequently, within the chosen group, individual tokens can now be assigned a priority, enabling fine-grained control over their selection order. This provides greater flexibility and control for administrators in managing and optimizing token usage, ensuring that critical or preferred tokens are utilized effectively. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| func parsePriorityValue(v any) (int, bool) { | ||
| switch raw := v.(type) { | ||
| case float64: | ||
| return int(raw), true | ||
| case int: | ||
| return raw, true | ||
| case int64: | ||
| return int(raw), true | ||
| case json.Number: | ||
| if n, err := raw.Int64(); err == nil { | ||
| return int(n), true | ||
| } | ||
| return 0, false | ||
| case string: | ||
| trimmed := strings.TrimSpace(raw) | ||
| if trimmed == "" { | ||
| return 0, false | ||
| } | ||
| n, err := strconv.Atoi(trimmed) | ||
| if err != nil { | ||
| return 0, false | ||
| } | ||
| return n, true | ||
| default: | ||
| return 0, false | ||
| } | ||
| } |
There was a problem hiding this comment.
这个 parsePriorityValue 函数在 sdk/auth/filestore.go 中有重复。为了避免代码重复并提高可维护性，应将此逻辑集中化。可以考虑将此函数移动到 sdk/cliproxy/auth 包中（例如，在 priority.go 文件里），并将其导出为 ParsePriorityFromInterface。这样，此文件和 sdk/auth/filestore.go 都可以使用这个共享函数。
sdk/auth/filestore.go
Outdated
| func parsePriorityValue(v any) (int, bool) { | ||
| switch raw := v.(type) { | ||
| case float64: | ||
| return int(raw), true | ||
| case int: | ||
| return raw, true | ||
| case int64: | ||
| return int(raw), true | ||
| case json.Number: | ||
| if n, err := raw.Int64(); err == nil { | ||
| return int(n), true | ||
| } | ||
| return 0, false | ||
| case string: | ||
| trimmed := strings.TrimSpace(raw) | ||
| if trimmed == "" { | ||
| return 0, false | ||
| } | ||
| n, err := strconv.Atoi(trimmed) | ||
| if err != nil { | ||
| return 0, false | ||
| } | ||
| return n, true | ||
| default: | ||
| return 0, false | ||
| } | ||
| } |
There was a problem hiding this comment.
这个 parsePriorityValue 函数是 internal/api/handlers/management/auth_files.go 中函数的副本。为了提高可维护性，应在此处删除该函数，并使用共享版本。我已在另一个文件中提出了建议，将此逻辑移动到 sdk/cliproxy/auth 包中。
| if index >= 2_147_483_640 { | ||
| index = 0 | ||
| } |
There was a problem hiding this comment.
数字 2_147_483_640 像是一个魔法数，可能意在防止 32 位系统上的整数溢出，因为它接近 math.MaxInt32。为了更好的清晰度和可维护性，最好使用命名常量或更具自描述性的值。例如，您可以定义一个像 const maxRoundRobinIndex = 2_000_000_000 这样的常量，或者直接使用一个大的整数，以清楚地表明其用途。
| if index >= 2_147_483_640 { | |
| index = 0 | |
| } | |
| if index >= 2_000_000_000 { // 重置以避免溢出 | |
| index = 0 | |
| } |
1 participant
优先级池子