-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(translator): restore usageMetadata in Gemini responses from Antigravity #1298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(translator): restore usageMetadata in Gemini responses from Antigravity #1298
Conversation
…ravity When using Gemini API format with Antigravity backend, the executor renames usageMetadata to cpaUsageMetadata in non-terminal chunks. The Gemini translator was returning this internal field name directly to clients instead of the standard usageMetadata field. Add restoreUsageMetadata() to rename cpaUsageMetadata back to usageMetadata before returning responses to clients.
Summary of ChangesHello @sususu98, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where Gemini API responses, when processed through the Antigravity backend, incorrectly contained Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes an issue where cpaUsageMetadata was being returned instead of the expected usageMetadata. The solution, which involves adding a restoreUsageMetadata function and applying it in both streaming and non-streaming response handlers, is well-implemented. The accompanying unit tests are thorough and cover the new logic effectively. I have one suggestion to improve the error handling in the new restoreUsageMetadata function to make it more robust against potential data inconsistencies.
| chunk, _ = sjson.SetRawBytes(chunk, "usageMetadata", []byte(cpaUsage.Raw)) | ||
| chunk, _ = sjson.DeleteBytes(chunk, "cpaUsageMetadata") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring errors from sjson operations can lead to returning a partially modified JSON object. If SetRawBytes succeeds but DeleteBytes fails, the resulting chunk will contain both usageMetadata and cpaUsageMetadata. It's safer to handle these errors and return the original chunk on failure to ensure the rename operation is atomic.
res, err := sjson.SetRawBytes(chunk, "usageMetadata", []byte(cpaUsage.Raw))
if err != nil {
return chunk
}
res, err = sjson.DeleteBytes(res, "cpaUsageMetadata")
if err != nil {
return chunk
}
chunk = res
Summary
Fixes #1297
When using Gemini API format with Antigravity backend, the response incorrectly contains
cpaUsageMetadatainstead of the standardusageMetadatafield.Changes
restoreUsageMetadata()function to renamecpaUsageMetadataback tousageMetadataConvertAntigravityResponseToGemini) and non-streaming (ConvertAntigravityResponseToGeminiNonStream) responsesRoot Cause
In #747,
StripUsageMetadataFromJSONwas introduced to renameusageMetadatatocpaUsageMetadatain non-terminal chunks. This was designed for the Claude translator to consume, but the Gemini translator was not updated to restore the original field name before returning responses to clients.Testing
go test ./internal/translator/antigravity/gemini/... -vAll tests pass including new tests for
restoreUsageMetadata.