Missing trace output on syslog level writer#579
Open
Conversation
Author
|
The code like this |
Author
|
Fixed, some error in ut |
Contributor
|
I think this was done on purpose. Mapping zerolog trace to syslog debug might be surprising to people. Syslog does not have trace equivalent. I think this could be instead better done with some custom LevelWriter which would map trace level to debug level and then you pass that on to syslog writer. Then it is explicit what you want to do. It is then just a question of your configuration. I think existing zerolog syslog implementation is fine as is. |
Contributor
|
I realized that it is not really possible to map level inside a writer because you would also have to change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like the title. When i want to use the syslog level writer + syslog output send messages. All others , e.g. "debug", "info" .. worked well. But the trace func , i got empty from syslog service( using journald )
I found there has a missing in syslog.go WriteLevel .
I also created a issues #578 ,