Open
Conversation
Also, raised text coverage for the journald sub-package to 92.2% Fixes rs#668
There was a problem hiding this comment.
Pull request overview
This PR adds sanitization of journald keys to handle invalid characters (such as dots) that are not allowed by journald, addressing issue #668. It also increases test coverage for the journald sub-package to 92.2%.
Changes:
- Implemented
SanitizeKeyfunction that converts keys to uppercase and replaces invalid characters with underscores - Added
SendFuncglobal variable for mocking journald interactions in tests - Added comprehensive test coverage including tests for key sanitization, various data types, all log levels, and error handling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| journald/journald.go | Implements key sanitization logic and test hook for mocking |
| journald/journald_test.go | Adds comprehensive tests for sanitization and various edge cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Made sanitizeKey package-private. Ensure the key starts with a letter. Added warning when SendFunc is replaced about parallel threads Moved test into package.
IDisposable
force-pushed
the
fix/sanitize-keys
branch
from
aa05d37 to
d659c1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, raised text coverage for the journald sub-package to 92.6%
Fixes #668