pwb: Add top-level components key with Positron#818
Draft
bschwedler wants to merge 2 commits intomainfrom
Draft
Conversation
bschwedler
force-pushed
the
worktree-workbench-session-init
branch
2 times, most recently
from
9813ec3 to
508d490
Compare
bschwedler
commented
Mar 30, 2026
Comment on lines
+54
to
+56
| {{- $_ := set $defaultRServerConfigValues "launcher-sessions-auto-update" 1 }} | ||
| {{- $_ := set $defaultRServerConfigValues "launcher-sessions-init-container-image-name" .Values.session.components.sessionInit.repository }} | ||
| {{- $_ := set $defaultRServerConfigValues "launcher-sessions-init-container-image-tag" $initTag }} |
Contributor
Author
There was a problem hiding this comment.
Similar config values required for the positron init container
launcher-positron-init-container-enabled
launcher-positron-init-container-image-name
launcher-positron-init-container-image-tag
bschwedler
commented
Mar 30, 2026
Comment on lines
+130
to
+134
| session: | ||
| image: | ||
| repository: "rstudio/r-session-complete" | ||
| components: | ||
| enabled: false |
Contributor
Author
There was a problem hiding this comment.
Using this structure for the workbench-positron-init container does not really make sense.
That init container needs to be included in both the workbench pod AND the session pod.
bschwedler
changed the title
bschwedler
force-pushed
the
worktree-workbench-session-init
branch
from
508d490 to
be121d9
Compare
Default the chart to using workbench-session and
workbench-session-init containers.
- Add top-level `components` key with `enabled` toggle
(default true) for session component init containers
- Configure rserver.conf with launcher-sessions-auto-update
and launcher-sessions-init-container-image-{name,tag}
when both launcher and components are enabled
- sessionInit image tag defaults to appVersion; can be
overridden via components.sessionInit.image.tag
- When launcher is disabled, components are silently ignored
- Bump chart version to 0.11.0 (breaking change)
Add support for updating the Positron IDE version independently of a Workbench release. A default Positron version is already delivered by the workbench-session-init container; this allows overriding it with a specific version. - Add components.positron with version and image sub-keys - Configure rserver.conf with positron init container settings when components.positron.version is set - Attach positron-init container to server pod with emptyDir volume mounted at the version-specific path - image.tag defaults to the positron version but can be overridden independently for custom builds Co-authored-by: Skye Turriff <turriff.skye@gmail.com>
bschwedler
force-pushed
the
worktree-workbench-session-init
branch
from
be121d9 to
209c798
Compare
ssinnott
approved these changes
Apr 1, 2026
skyeturriff
approved these changes
Apr 1, 2026
Contributor
skyeturriff
left a comment
skyeturriff
left a comment
There was a problem hiding this comment.
this looks awesome! just one minor comment!
|
|
||
| ### Positron | ||
|
|
||
| To enable Positron IDE support, set a Positron version under `components.positron`: |
Contributor
There was a problem hiding this comment.
We might want to adjust wording here, it kind of sounds like Positron won't work without it. Something closer to what was added to the NEWS entry would make sense I think.
Suggested change
| To enable Positron IDE support, set a Positron version under `components.positron`: | |
| Positron IDE is available by default. The `workbench-session-init` container delivers a bundled Positron version alongside other session components. | |
| To update Positron independently of a Workbench release, set a version under `components.positron`: | |
| components: | |
| positron: | |
| version: "2026.03.0" | |
| This attaches a separate init container that delivers the specified Positron version and its documentation, overriding the bundled version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default the chart to using
workbench-sessionandworkbench-session-initcontainers, and add support for updating the Positron IDE version independently of a Workbench release.componentskey withenabledtoggle (defaulttrue) for session component init containersrserver.confwithlauncher-sessions-auto-updateandlauncher-sessions-init-container-image-{name,tag}when both launcher and components are enabledcomponents.positronfor Positron init container; setversionto enable,image.tagto override for custom buildsrserver.conffor session pod injectionsession.image.repository: rstudio/r-session-completeandcomponents.enabled: false0.11.0(breaking change)