Security: Fix unsafe pointer buffer overread in TextualStl parser#90
Open
trek-e wants to merge 2 commits intorubenwe:masterfrom
Open
Security: Fix unsafe pointer buffer overread in TextualStl parser#90trek-e wants to merge 2 commits intorubenwe:masterfrom
trek-e wants to merge 2 commits intorubenwe:masterfrom
Conversation
- STACK.md - Technologies and dependencies - ARCHITECTURE.md - System design and patterns - STRUCTURE.md - Directory layout - CONVENTIONS.md - Code style and patterns - TESTING.md - Test structure - INTEGRATIONS.md - External services - CONCERNS.md - Technical debt and issues
The text-based STL parser used unsafe pointer operations without bounds checking, allowing malformed files to cause out-of-bounds memory reads. This fix adds: - End-of-buffer pointer tracking throughout all parsing methods - Bounds checks before every pointer dereference - Maximum facet count limit (10M) to prevent memory exhaustion - Graceful handling of truncated/malformed files Security impact: - Prevents out-of-bounds memory reads from malicious STL files - Prevents denial of service via memory exhaustion Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TextualStl.csSecurity Impact
Changes
endOfFilepointer tracking throughout all parsing methodsboolfor graceful failure handlingTest plan
🤖 Generated with Claude Code