Migrate the typography components to align with Phlex conversions#168
Merged
stephannv merged 2 commits intoruby-ui:mainfrom Feb 19, 2025
Merged
Conversation
stephannv
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phlex 2.0 follows a specific folder structure and naming convention for views and components.
For views, they should be placed in the
app/viewsdirectory under theViewsnamespace, and must inherit fromViews::Base.For components, they should be placed in the
app/componentsdirectory under theComponentsnamespace, and must inherit fromComponents::Base.This pull request continues the migration of the components that are currently in the
app/views/componentsfolder toapp/components, in accordance with the Phlex conventions.PS: I took the opportunity to remove unused files.