Fix bundle console unnecessarily trying to load IRB twice#8443
Merged
deivid-rodriguez merged 2 commits intomasterfrom Jan 29, 2025
Merged
Conversation
These gems always define their main namespace and I don't think that will ever change.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/remove-unnecessary-console-fallback
branch
from
7806b99 to
f9bf585
Compare
deivid-rodriguez
deleted the
deivid-rodriguez/remove-unnecessary-console-fallback
branch
deivid-rodriguez
added a commit
that referenced
this pull request
Feb 17, 2025
…ssary-console-fallback Fix `bundle console` unnecessarily trying to load IRB twice (cherry picked from commit 790a202)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Ruby 3.5 moves irb to a bundled gem, so it may not always be available. If that happens, bundle console will try to load IRB again with the message
which makes little sense to do and will always fail.
What is your fix for the problem, implemented in this PR?
Don't try to fallback to IRB if IRB was tried in the first place.
Fixes the little issue mentioned in #8396 (comment).
Make sure the following tasks are checked