Support YAML !binary tag in YAMLSerializer#9393
Merged
hsbt merged 2 commits intofix-binary-gemfrom Mar 12, 2026
Merged
Conversation
4 tasks
Co-authored-by: hsbt <12301+hsbt@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for YAML
Support YAML Mar 12, 2026
!binary tag in YAMLSerializer!binary tag in YAMLSerializer
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves RubyGems’ Psych-less YAML parsing path by teaching Gem::YAMLSerializer to handle YAML 1.1 !binary (base64) scalars, which appear in older gems’ checksums.yaml.gz and can otherwise break installs.
Changes:
- Add support in
Gem::YAMLSerializer::Parserfor base64-decoding!binaryscalars across mappings (keys/values) and sequences. - Add a regression test covering the inline sequence-item
!binarycase (- !binary "...").
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/rubygems/yaml_serializer.rb | Extends the YAMLSerializer parser to recognize and decode !binary-tagged scalars via base64. |
| test/rubygems/test_gem_safe_yaml.rb | Adds coverage for decoding !binary used as an inline sequence item. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Gems packaged with older RubyGems encode
checksums.yaml.gzvalues using YAML 1.1!binarytags (base64). When Psych is disabled/unavailable,Gem::YAMLSerializerfailed to parse these, causing gem install failures.What is your fix for the problem, implemented in this PR?
Extended
Gem::YAMLSerializer::Parserto base64-decode scalars tagged with!binaryin:Also adds test coverage for the sequence item code path (
- !binary "..."), which was missing from the initial implementation.Make sure the following tasks are checked
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.