feat: implement --ignore-vcs-status-names for GitLab - #5954
Open
jklong wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
docs
Author
|
@lukemassa is there anything you want from me in order to move this forward? |
lukemassa
previously approved these changes
Nov 30, 2025
Contributor
|
Looks good to me! |
jklong
force-pushed
the
gitlab-ignore-vcs-status
branch
from
December 18, 2025 23:13
1ed5d32 to
6ada326
Compare
Author
|
Sigh, I accidentally clicked a wrong button somewhere and clobbered my changes :/. I'll fix it up and reopen, standby |
Author
|
There we go, rebased everything onto runatlantis:main and fixed the branch. |
Author
|
@lukemassa sorry about that. Exactly the same change, just rebased. Can you please reapprove the PR and the pending workflows (assuming thats what's blocking merging)? |
lukemassa
previously approved these changes
Dec 20, 2025
Signed-off-by: James Longmore <jlongmore@cloudflare.com>
jklong
force-pushed
the
gitlab-ignore-vcs-status
branch
from
December 21, 2025 23:55
e864024 to
e7a1c8a
Compare
Contributor
|
@jklong could you please resolve the conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Implement the
--ignore-vcs-status-namesflag for the GitLab provider. Similar to #4978, this consults an ignore list when for commit status names when determining mergeability. If a commit status name can be parsed as{vcsstatusname}/...and that parsedvcsstatusnameis present in the configured ignore list then it is skipped.why
Similar reasoning as expressed in #2848 for the existing GitHub-only feature - when multiple atlantis servers with different
vcs-status-namesoperate on a single repo with amergeablerequirement they see pending pipeline statuses set by the other atlantis instances and report that the MR is not mergeable.tests
go test ./server/events/vcspasses, however an existing, unrelated, test failure at main/HEAD causesmake testto fail.references
#2848
#4978