Skip to content

fix: production Docker builds and GPU/CPU tag consistency #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deanq merged 1 commit into from
Aug 6, 2025
Merged

fix: production Docker builds and GPU/CPU tag consistency #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ jobs:
docker-prod:
runs-on: ubuntu-latest
needs: [release]
if: needs.release.outputs.release_created
if: needs.release.outputs.release_created || (github.ref == 'refs/heads/main' && needs.release.outputs.tag_name)
steps:
- name: Clear Space
run: |
Expand Down Expand Up @@ -296,8 +296,8 @@ jobs:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}

- name: Extract metadata
id: meta
- name: Extract GPU metadata
id: meta-gpu
uses: docker/metadata-action@v5
with:
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
Expand All @@ -309,6 +309,19 @@ jobs:
type=semver,pattern={{major}}
type=raw,value=latest,enable={{is_default_branch}}

- name: Extract CPU metadata
id: meta-cpu
uses: docker/metadata-action@v5
with:
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}-cpu
tags: |
type=ref,event=branch
type=ref,event=pr
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
type=semver,pattern={{major}}
type=raw,value=latest,enable={{is_default_branch}}

- name: Set up uv
uses: astral-sh/setup-uv@v4
with:
Expand All @@ -327,8 +340,8 @@ jobs:
file: ./Dockerfile
platforms: linux/amd64
push: true
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
tags: ${{ steps.meta-gpu.outputs.tags }}
labels: ${{ steps.meta-gpu.outputs.labels }}
cache-from: type=gha
cache-to: type=gha,mode=max

Expand All @@ -339,9 +352,7 @@ jobs:
file: ./Dockerfile-cpu
platforms: linux/amd64
push: true
tags: |
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}-cpu:${{ needs.release.outputs.tag_name }}
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}-cpu:latest
labels: ${{ steps.meta.outputs.labels }}
tags: ${{ steps.meta-cpu.outputs.tags }}
labels: ${{ steps.meta-cpu.outputs.labels }}
cache-from: type=gha
cache-to: type=gha,mode=max
Loading