Skip to content

Add the simplest heap#104

Closed
JalonWong wants to merge 1 commit into
rust-embedded:masterfrom
JalonWong:simplest
Closed

Add the simplest heap#104
JalonWong wants to merge 1 commit into
rust-embedded:masterfrom
JalonWong:simplest

Conversation

@JalonWong

@JalonWong JalonWong commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

It's very useful on a resource-constrained platform and avoids the need to use heapless modules. Its usage is the same as other heaps.
Because it's the simplest implementation, it doesn't free memory. Any memory you drop cannot be reused (it's leaked), so avoid dropping anything whenever possible.

@JalonWong JalonWong requested a review from a team as a code owner August 15, 2025 17:37
@JalonWong JalonWong closed this Aug 15, 2025
@zeenix

zeenix commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

@JalonWong ?

@JalonWong

JalonWong commented Aug 15, 2025

Copy link
Copy Markdown
Contributor Author

@JalonWong ?

@zeenix Sorry, I will open the PR again when I fix CI errors.

@zeenix

zeenix commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

@JalonWong ?

@zeenix Sorry, I will open the PR again when I fix CI errors.

Thanks. Please also provide a bit of rationale/use case in the PR description and commit messages while you're at it. 🙏

@JalonWong

Copy link
Copy Markdown
Contributor Author

@zeenix I have fixed all errors. But I'm not familiar with the permission of GitHub PR. Should I create a new one, or how can I reopen it?
I will add more descriptions later.

@zeenix

zeenix commented Aug 16, 2025

Copy link
Copy Markdown
Contributor

But I'm not familiar with the permission of GitHub PR. Should I create a new one, or how can I reopen it?

I don't have permission to re-open either. I guess it's a bit too late. You shouldn't have closed the new PR. It was already there so we end up with every more noise. :( Anyway, please keep in mind in the future to do you best to reduce noise and number of PRs.

@zeenix

zeenix commented Aug 16, 2025

Copy link
Copy Markdown
Contributor

I guess it's a bit too late.

I meant here that you'll need to create another PR (but let's not close that one 😉).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants