Conversation
Contributor
Author
|
Closing - the download client examples have already been rewritten on master, removing error_chain in favor of anyhow. The core goal of this PR is already accomplished. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #683
rewrites the download to use the native
reqwestchunk,anyhowerrors and async all the places.🎉 Hi and welcome! Please read the text below and remove it - Thank you! 🎉
No worries if anything in these lists is unclear. Just submit the PR and ask away! 👍
Things to check before submitting a PR
cargo testmdbook serve -o./ci/spellcheck.shlink-checker ./bookhttps://docs.rs/tar/*/tar/struct.Entry.htmlThings to do after submitting PR
Thank you for reading, you may now delete this text! Thank you! 😄